Opened 16 years ago

Closed 8 years ago

#38 closed enhancement (fixed)

Link styles are ugly

Reported by: Dominic Hargreaves Owned by: Nobody
Priority: low Milestone:
Component: openguides Version:
Severity: minor Keywords:
Cc:

Description

From http://oxford.openguides.org/wiki/?Comments:

Square brackets around links to external pages look ugly. Is there any chance of preventing them from being displayed? -- James

  • Not that I know of. I actually disagree in any case; it's a useful way of distinguishing between internal and external links, so I'd rather the convention was kept. --Dom
  • Couldn't that be done within the stylesheet? --James
  • Stylesheet sounds like the best plan. I'll look into it unless someone else does first. --Kake

Attachments (1)

link_bracket_css_test.html (346 bytes) - added by Earle Martin 14 years ago.
Demo of using CSS to display brackets around links.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 16 years ago by crschmidt@…

This is a change in CGI::Wiki::Formatter::UseMod, probably copied over from the time when OpenGuides was originally moved over from GrubStreet. I'm not sure what the best way is to do this, but I would really prefer to be able to somehow set the formatter that OpenGuides is using. This doesn't need to be a config option neccesarily, but something easy to change in wiki.conf would be good...

Looking at it, it looks like $formatter = $wiki->formatter; in the first line of the wiki.cgi can actually control all of the formatting. so, if you want to do this, the best way to do it would be to copy the UseMod formatter, create an "OpenGuides" (or an "OpenGuides::oxford") formatter, then set that formatter variable in the wiki.cgi. This keeps it from being another config option to confuse people, but allows most people to chnage it themselves.

comment:2 Changed 16 years ago by Dominic Hargreaves

I disagree; wiki.cgi should not contain configuration!

comment:3 Changed 16 years ago by Earle Martin

I think we should probably have an OpenGuides::Formatter which could be configured to be a subclass of CGI::Wiki::Formatter::UseMod. Then we could pass it specific options, etcetera.

comment:4 Changed 15 years ago by Dominic Hargreaves

Priority: normallow
Severity: normalminor
Type: defectenhancement

This doesn't seem to be something that people care about greatly.

comment:5 Changed 14 years ago by Dominic Hargreaves

Owner: changed from Dominic Hargreaves to Nobody

Changed 14 years ago by Earle Martin

Attachment: link_bracket_css_test.html added

Demo of using CSS to display brackets around links.

comment:6 Changed 14 years ago by Earle Martin

I suggest that we remove bracketing from the Perl and do it with CSS. See attachment.

comment:7 Changed 14 years ago by Earle Martin

Oh well, that technique isn't supported by Internet Explorer yet (sigh). Never mind.

comment:8 Changed 9 years ago by bob

comment:9 Changed 8 years ago by Dominic Hargreaves

Resolution: fixed
Status: newclosed

this formatting got changed at some point. Resolving fixed.

Note: See TracTickets for help on using tickets.