Opened 14 years ago

Closed 13 years ago

#222 closed defect (fixed)

node_image div shouldn't be within metadata div

Reported by: Kake Owned by: Dominic Hargreaves
Priority: normal Milestone:
Component: openguides Version: svn
Severity: normal Keywords:
Cc:

Description

At the moment, the <div> containing the node image is contained within the metadata <div>. This really limits the possible ways to style the page — it looks OK if you don't have inline Google maps turned on (e.g. RGL) but it doesn't seem possible to make the page not ugly if you have them turned on; e.g. http://the.earth.li/~kake/cgi-bin/openguides/vegan-oxford.cgi?Inner_Bookshop and http://saintpaul.openguides.org/index.cgi?Mickey%27s_Diner

It doesn't make sense semantically either - the node image itself isn't metadata (although its URI and associated data are).

The node image div should be separate from the metadata one.

Attachments (2)

node_image.display_metadata.patch (1.0 KB) - added by perigrin 14 years ago.
patch to display_image.tt to move node_image data
node_image.node.patch (914 bytes) - added by perigrin 14 years ago.
patch to node.tt to add node_image metadata

Download all attachments as: .zip

Change History (5)

Changed 14 years ago by perigrin

patch to display_image.tt to move node_image data

Changed 14 years ago by perigrin

Attachment: node_image.node.patch added

patch to node.tt to add node_image metadata

comment:1 Changed 14 years ago by perigrin

I have added two patches that moves node_image metadata out of display_metadata.tt into node.tt beside the map. I've implemented this on the St. Paul link above (http://saintpaul.openguides.org/index.cgi?Mickey%27s_Diner)

comment:2 Changed 13 years ago by Dominic Hargreaves

Owner: changed from Nobody to Dominic Hargreaves
Status: newassigned

comment:3 Changed 13 years ago by Dominic Hargreaves

Resolution: fixed
Status: assignedclosed

(In [1237]) Move the node image outside the metadata div, to aid styling (fixes #222). Thanks peregrin.

Note: See TracTickets for help on using tickets.