Opened 15 years ago

Closed 13 years ago

#132 closed enhancement (wontfix)

Standardise pages

Reported by: cds Owned by: Nobody
Priority: low Milestone:
Component: openguides Version: svn
Severity: trivial Keywords: patch
Cc:

Description

Different pages seem to use templates differently - the history pages doesn't have a #content - the edit page doesn't even have a navbar! It would be a lot easier to customise if it was all standardised.

Attachments (16)

backlink_results.tt (403 bytes) - added by cds 15 years ago.
custom_banner.tt (82 bytes) - added by cds 15 years ago.
differences.tt (921 bytes) - added by cds 15 years ago.
display_metadata.tt (2.4 KB) - added by cds 15 years ago.
edit_conflict.tt (4.7 KB) - added by cds 15 years ago.
edit_form.tt (5.4 KB) - added by cds 15 years ago.
footer.tt (1.2 KB) - added by cds 15 years ago.
node.tt (4.3 KB) - added by cds 15 years ago.
node_history.tt (1.4 KB) - added by cds 15 years ago.
preferences.tt (5.9 KB) - added by cds 15 years ago.
recent_changes.tt (2.7 KB) - added by cds 15 years ago.
search.tt (3.8 KB) - added by cds 15 years ago.
search_results.tt (489 bytes) - added by cds 15 years ago.
site_index.tt (884 bytes) - added by cds 15 years ago.
userstats.tt (1.5 KB) - added by cds 15 years ago.
wanted_pages.tt (659 bytes) - added by cds 15 years ago.

Download all attachments as: .zip

Change History (28)

comment:1 Changed 15 years ago by cds

Milestone: 0.57
Owner: changed from Dominic Hargreaves to cds

I've gone ahead and taken this - merely because I've fixed it myself, so can upload the new template files.

Changed 15 years ago by cds

Attachment: backlink_results.tt added

Changed 15 years ago by cds

Attachment: custom_banner.tt added

Changed 15 years ago by cds

Attachment: differences.tt added

Changed 15 years ago by cds

Attachment: display_metadata.tt added

Changed 15 years ago by cds

Attachment: edit_conflict.tt added

Changed 15 years ago by cds

Attachment: edit_form.tt added

Changed 15 years ago by cds

Attachment: footer.tt added

Changed 15 years ago by cds

Attachment: node.tt added

Changed 15 years ago by cds

Attachment: node_history.tt added

Changed 15 years ago by cds

Attachment: preferences.tt added

Changed 15 years ago by cds

Attachment: recent_changes.tt added

Changed 15 years ago by cds

Attachment: search.tt added

Changed 15 years ago by cds

Attachment: search_results.tt added

Changed 15 years ago by cds

Attachment: site_index.tt added

Changed 15 years ago by cds

Attachment: userstats.tt added

Changed 15 years ago by cds

Attachment: wanted_pages.tt added

comment:2 Changed 15 years ago by Dominic Hargreaves

Owner: changed from cds to Dominic Hargreaves
Status: newassigned

comment:3 Changed 15 years ago by Dominic Hargreaves

Keywords: patch added

comment:4 Changed 15 years ago by Dominic Hargreaves

Note for self: the attached templates are based on 0.56, so diff against [810].

comment:5 Changed 15 years ago by Dominic Hargreaves

Resolution: fixed
Status: assignedclosed

(In [849]) Tidies up various template bugs (closes #132, #133)

comment:6 Changed 15 years ago by cds

Resolution: fixed
Status: closedreopened

I'm going to reopen this, since there's still issues with the templates, such as the seemingly random switch between h1, h2, and centre aligned page titles, the edit form (which seems to break whenever there's space on the left for the sidebar, which there is - probably my fault), and the footer licence info.

comment:7 Changed 15 years ago by Dominic Hargreaves

Clair,

I applied some of your changes, but other changes were not suitable for inclusion due to their arbitrarily changing existing styles and other customisations. It's possible that I missed some changes that should have gone in as they were tied up with such changes.

Please can you be more specific about what you think is wrong with the current templates, preferably as a patch against SVN.

comment:8 Changed 15 years ago by nick

(In [869]) Fix space after licence name. References #132

comment:9 Changed 15 years ago by cds

I understand why some changes weren't made, which isn't a problem. Those that I'm thinking of are:

  • The space after the licence name problem
  • The <br> before the footer... this leaves a gap which may not be wanted, and could easily be implemented by a clear=both in the CSS
  • I think the most common links could be put into the navbar, rather than the bottom of the node name.
  • The new RSS links for the category list, recent changes etc, aren't inside the maincontent div, which messes up things.
  • I'm not so sure about the choice of <h1>/<h2>. It appears some pages are h1, while some are h2. Although I might be missing out a reasoning behind.

I realise some of these are new to the latest version, so I'm not saying I'm reopening this ticket because all of my changes aren't included. Far from it :)

comment:10 Changed 15 years ago by Dominic Hargreaves

Milestone: 0.58

comment:11 Changed 14 years ago by Dominic Hargreaves

Owner: changed from Dominic Hargreaves to Nobody
Status: reopenednew

comment:12 Changed 13 years ago by Dominic Hargreaves

Resolution: wontfix
Status: newclosed

Some of these issues remain, but belong more to #37 (general CSS hacking) or are personal taste issues. Resolving wontfix.

Note: See TracTickets for help on using tickets.