Ticket #132 (new enhancement)

Opened 2 years ago

Last modified 16 months ago

Standardise pages

Reported by: cds Owned by: Nobody
Priority: low Milestone:
Component: openguides Version: svn
Severity: trivial Keywords: patch
Cc:

Description

Different pages seem to use templates differently - the history pages doesn't have a #content - the edit page doesn't even have a navbar! It would be a lot easier to customise if it was all standardised.

Attachments

backlink_results.tt (403 bytes) - added by cds 2 years ago.
custom_banner.tt (82 bytes) - added by cds 2 years ago.
differences.tt (0.9 kB) - added by cds 2 years ago.
display_metadata.tt (2.4 kB) - added by cds 2 years ago.
edit_conflict.tt (4.7 kB) - added by cds 2 years ago.
edit_form.tt (5.4 kB) - added by cds 2 years ago.
footer.tt (1.2 kB) - added by cds 2 years ago.
node.tt (4.3 kB) - added by cds 2 years ago.
node_history.tt (1.4 kB) - added by cds 2 years ago.
preferences.tt (5.9 kB) - added by cds 2 years ago.
recent_changes.tt (2.7 kB) - added by cds 2 years ago.
search.tt (3.8 kB) - added by cds 2 years ago.
search_results.tt (489 bytes) - added by cds 2 years ago.
site_index.tt (0.9 kB) - added by cds 2 years ago.
userstats.tt (1.5 kB) - added by cds 2 years ago.
wanted_pages.tt (0.6 kB) - added by cds 2 years ago.

Change History

Changed 2 years ago by cds

  • owner changed from dom to cds
  • milestone set to 0.57

I've gone ahead and taken this - merely because I've fixed it myself, so can upload the new template files.

Changed 2 years ago by cds

Changed 2 years ago by cds

Changed 2 years ago by cds

Changed 2 years ago by cds

Changed 2 years ago by cds

Changed 2 years ago by cds

Changed 2 years ago by cds

Changed 2 years ago by cds

Changed 2 years ago by cds

Changed 2 years ago by cds

Changed 2 years ago by cds

Changed 2 years ago by cds

Changed 2 years ago by cds

Changed 2 years ago by cds

Changed 2 years ago by cds

Changed 2 years ago by cds

Changed 2 years ago by dom

  • owner changed from cds to dom
  • status changed from new to assigned

Changed 2 years ago by dom

  • keywords patch added

Changed 2 years ago by dom

Note for self: the attached templates are based on 0.56, so diff against [810].

Changed 2 years ago by dom

  • status changed from assigned to closed
  • resolution set to fixed

(In [849]) Tidies up various template bugs (closes #132, #133)

Changed 2 years ago by cds

  • status changed from closed to reopened
  • resolution fixed deleted

I'm going to reopen this, since there's still issues with the templates, such as the seemingly random switch between h1, h2, and centre aligned page titles, the edit form (which seems to break whenever there's space on the left for the sidebar, which there is - probably my fault), and the footer licence info.

Changed 2 years ago by dom

Clair,

I applied some of your changes, but other changes were not suitable for inclusion due to their arbitrarily changing existing styles and other customisations. It's possible that I missed some changes that should have gone in as they were tied up with such changes.

Please can you be more specific about what you think is wrong with the current templates, preferably as a patch against SVN.

Changed 2 years ago by nick

(In [869]) Fix space after licence name. References #132

Changed 2 years ago by cds

I understand why some changes weren't made, which isn't a problem. Those that I'm thinking of are: * The space after the licence name problem * The <br> before the footer... this leaves a gap which may not be wanted, and could easily be implemented by a clear=both in the CSS * I think the most common links could be put into the navbar, rather than the bottom of the node name. * The new RSS links for the category list, recent changes etc, aren't inside the maincontent div, which messes up things. * I'm not so sure about the choice of <h1>/<h2>. It appears some pages are h1, while some are h2. Although I might be missing out a reasoning behind.

I realise some of these are new to the latest version, so I'm not saying I'm reopening this ticket because all of my changes aren't included. Far from it :)

Changed 22 months ago by dom

  • milestone 0.58 deleted

Changed 16 months ago by dom

  • owner changed from dom to Nobody
  • status changed from reopened to new
Note: See TracTickets for help on using tickets.