Changeset 243

Timestamp:

09/23/03 17:10:12 (5 years ago)

Author:

kake

Message:

OK, we need CGI::Wiki 0.49 for proper case-insensitivity.

Location:

trunk

Files:

• Build.PL (modified) (1 diff)
• Changes (modified) (1 diff)
• PREREQUISITES (modified) (1 diff)
• lib/OpenGuides/SuperSearch.pm (modified) (2 diffs)
• t/31_supersearch.t (modified) (3 diffs)
• t/32_supersearch_simple_metadata.t (modified) (4 diffs)

trunk/Build.PL

@@ -194 +194 @@
         'CGI::Carp' => 0,
         'CGI::Cookie' => 0,
-        'CGI::Wiki' => '0.47',
-        'CGI::Wiki::Formatter::UseMod' => '0.07', # for nested lists and bugfix
+        'CGI::Wiki' => '0.49',
+        'CGI::Wiki::Formatter::UseMod' => '0.09',
         'CGI::Wiki::Plugin::Categoriser' => 0,
         'CGI::Wiki::Plugin::GeoCache' => 0,

trunk/Changes

@@ -3 +3 @@
         Search box now searches categories and locales as well as title and
           body - so for example a search on "holborn & pubs" will DTRT.
+        NOT and phrase search tests were passing even though they shouldn't
+          have been - skip them for now.
 
 0.24    8 September 2003

trunk/PREREQUISITES

@@ -6 +6 @@
 CGI::Carp
 CGI::Cookie
-CGI::Wiki (version 0.47 or later)
-CGI::Wiki::Formatter::UseMod (version 0.07 or later)
+CGI::Wiki (version 0.49 or later)
+CGI::Wiki::Formatter::UseMod (version 0.09 or later)
 CGI::Wiki::Plugin::Categoriser
 CGI::Wiki::Plugin::GeoCache

trunk/lib/OpenGuides/SuperSearch.pm

@@ -190 +190 @@
     # Search categories.
     my @catmatches = $wiki->list_nodes_by_metadata(
-                         metadata_type => "category",
+                         metadata_type  => "category",
                          metadata_value => $search,
+                         ignore_case    => 1,
     );
 
@@ -204 +205 @@
     # Search locales.
     my @locmatches = $wiki->list_nodes_by_metadata(
-                         metadata_type => "locale",
+                         metadata_type  => "locale",
                          metadata_value => $search,
+                         ignore_case    => 1,
     );
     foreach my $node ( @locmatches ) {

trunk/t/31_supersearch.t

@@ -112 +112 @@
 
     # Test the NOT search
+SKIP: {
+    skip "NOT search doesn't work yet", 1;
     %tt_vars = $search->run(
                              return_tt_vars => 1,
@@ -120 +122 @@
                "NOT search returns right results" );
     print "# Found in $_\n" foreach @found;
+}
 
     # Test the phrase search
+SKIP: {
+    skip "phrase search doesn't work yet", 1;
     $output = $search->run(
                             return_output => 1,
@@ -130 +135 @@
           "phrase search returns right results"
         );
+}
 
     #####

trunk/t/32_supersearch_simple_metadata.t

@@ -50 +50 @@
                "simple search looks in category" );
 
-SKIP: {
-    skip "TODO - need case-insensitive metadata search", 1;
     %tt_vars = $search->run(
                              return_tt_vars => 1,
@@ -59 +57 @@
     is_deeply( \@found, [ "Calthorpe_Arms", "Calthorpe_Arms_2" ],
                "...and is case-insensitive" );
-}
 
     # Check that a search on its locale works.
@@ -70 +67 @@
                "simple search looks in locale" );
 
-SKIP: {
-    skip "TODO - need case-insensitive metadata search", 1;
     %tt_vars = $search->run(
                              return_tt_vars => 1,
@@ -79 +74 @@
     is_deeply( \@found, [ "Calthorpe_Arms", "Calthorpe_Arms_2" ],
                "...and is case-insensitive" );
-}
 
     # Test AND search in various combinations.