Changeset 1085 for trunk/preferences.cgi

Timestamp:

06/17/07 00:57:32 (17 months ago)

Author:

ilmari

Message:

Clean up fallout from prefs cleanup
- Make OpenGuides::Template->output pass the provided cookies to

OpenGuides::CGI->get_prefs_from_cookie, where this overrides any
browser-supplied cookie.

- Use the prefs hash explcitly where needed (fixes #216).

Targets to commit (you may delete items from it)

M /home/ilmari/src/openguides-trunk/lib/Changes.pm
M /home/ilmari/src/openguides-trunk/lib/OpenGuides/CGI.pm
M /home/ilmari/src/openguides-trunk/lib/OpenGuides/Template.pm
M /home/ilmari/src/openguides-trunk/preferences.cgi
M /home/ilmari/src/openguides-trunk/t/59_preferences.t
M /home/ilmari/src/openguides-trunk/templates/preferences.tt
M /home/ilmari/src/openguides-trunk/templates/navbar_tools.tt

Files:

• trunk/preferences.cgi (modified) (2 diffs)

trunk/preferences.cgi

@@ -31 +31 @@
     # If they've asked not to have their recent changes visits tracked,
     # clear any existing recentchanges cookie.
-    if ( ! $track_rc ) {
+    if ( ! $prefs{track_recent_changes_views} ) {
         my $rc_cookie = OpenGuides::CGI->make_recent_changes_cookie(
             config       => $config,
@@ -43 +43 @@
         template => "preferences.tt",
         cookies  => \@cookies,
-        vars     => {
-                      not_editable               => 1,
-                      %prefs,
+        vars     => {
+                      not_editable => 1,
                     }
     );