Ticket #192: openguides-fix-gmaps-pref.patch

templates/preferences.tt

@@ -66 +66 @@
       <label for="track_recent_changes_views">Track my visits to Recent Changes and offer me a link for &#8220;changes since I last viewed Recent Changes&#8221;.</label>
     </p>
 
-    [% IF gmaps_api_key %]
+    [% IF gmaps_api_key AND config.show_gmap_in_node_display %]
       <p>
         [% IF display_google_maps %]
           <input type="checkbox" id="display_google_maps" name="display_google_maps" value="1" checked="1" />
@@ -152 +152 @@
     [% UNLESS track_recent_changes_views %] not [% END %]
   be tracked.</p>
 
-  [% IF gmaps_api_key %]
+  [% IF gmaps_api_key AND config.show_gmap_in_node_display %]
     <p>Google Maps will
       [% UNLESS display_google_maps %] not [% END %]
     be displayed.</p>

t/59_preferences.t

@@ +1 @@
+use Wiki::Toolkit::Setup::SQLite;
+use OpenGuides;
+use OpenGuides::Test;
+use Test::More;
+
+eval { require DBD::SQLite; };
+
+if ( $@ ) {
+    my ($error) = $@ =~ /^(.*?)\n/;
+    plan skip_all => "DBD::SQLite could not be used - no database to test with ($error)";
+}
+
+eval { require DBD::SQLite; };
+if ( $@ ) {
+    plan skip_all => "DBD::SQLite not installed - no database to test with";
+    exit 0;
+}
+
+eval { require Test::HTML::Content; };
+if ( $@ ) {
+    plan skip_all => "Test::HTML::Content not installed";
+    exit 0;
+}
+
+plan tests => 2;
+
+Wiki::Toolkit::Setup::SQLite::cleardb( { dbname => "t/prefs.db" } );
+Wiki::Toolkit::Setup::SQLite::setup( { dbname => "t/prefs.db" } );
+my $config = OpenGuides::Test->make_basic_config;
+my $guide = OpenGuides->new( config => $config );
+my $wiki = $guide->wiki;
+
+$config->gmaps_api_key( "This is not a real API key." );
+$config->show_gmap_in_node_display( 1 );
+
+my $cookie = OpenGuides::CGI->make_prefs_cookie(
+                                                 config => $config,
+                                                 display_google_maps => 1,
+                                               );
+# If the google API is present and node maps are enabled, we should have the pref
+Test::HTML::Content::tag_ok( get_output($wiki, $config, $cookie), 'input', 
+                             { type => 'checkbox', name => 'display_google_maps' },
+                             'Google maps pref shown'
+                           );
+
+# But not if the node map is globally disabled
+$config->show_gmap_in_node_display( 0 );
+Test::HTML::Content::no_tag( get_output($wiki, $config, $cookie), 'input', 
+                             { type => 'checkbox', name => 'display_google_maps' },
+                             'No google maps prefs if node maps disabled'
+                           );
+
+sub get_output {
+    my ($wiki, $config) = @_;
+
+    return OpenGuides::Template->output(
+        wiki         => $wiki,
+        config       => $config,
+        template     => "preferences.tt",
+        content_type => '',
+        vars         => { OpenGuides::CGI->get_prefs_from_cookie( config => $config ),
+                          not_editable => 1,
+                          show_form    => 1
+                        },
+    );
+}
+

lib/OpenGuides/Template.pm

@@ -56 +56 @@
 Returns everything you need to send to STDOUT, including the
 Content-Type: header. Croaks unless C<template> is supplied.
 
-The variables supplied in C<vars> are passed through to the template
-specified.  Additional Template Toolkit variables are automatically
-set and passed through as well, as described below.  B<Note:>
-variables set in C<vars> will over-ride any variables of the same name
-in the config object or the user cookies.
+The config object and variables supplied in C<vars> are passed through
+to the template specified.  Additional Template Toolkit variables are
+automatically set and passed through as well, as described below.
+B<Note:> variables set in C<vars> will over-ride any variables of the
+same name in the config object or the user cookies.
 
 =over